-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final round #1582
base: master
Are you sure you want to change the base?
Final round #1582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix a few minor comments before approving!
src/App.tsx
Outdated
const [errorMessage, setErrorMessage] = useState<Errors | null>(null); | ||
const [processing, setProcessing] = useState<number>(-1); | ||
const [todosQuantity, setTodosQuantity] = useState(0); | ||
const [isEditing, setIsEditing] = useState<number | undefined>(undefined); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use null for empty value
src/Components/Main/TodoMain.tsx
Outdated
const handleChangeCompleted = () => { | ||
onUpdate({ | ||
...todo, | ||
completed: todo.completed ? false : true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completed: todo.completed ? false : true, | |
completed: todo.completed, |
can be a bit simplify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This iteration looks good to me, I'm approving it!
DEMO LINK