solution #1587
Open
solution #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StasSokolov1
suggested changes
Jan 7, 2025
src/App.tsx
Outdated
| try { | ||
| setLoadTodo({ | ||
| id: 0, | ||
| title: todoQuery.trim(), |
There was a problem hiding this comment.
let's move todoQuery.trim() into const and reuse
src/api/todos.ts
Outdated
| }; | ||
|
|
||
| export const addTodo = (todo: Omit<Todo, 'id' | 'userId' | 'completed'>) => { | ||
| return client.post<Todo>(`/todos`, { |
src/components/TodoComponent.tsx
Outdated
| try { | ||
| setIsToLoad(true); | ||
|
|
||
| if (todoTitle.trim() === '') { |
There was a problem hiding this comment.
todoTitle.trim() move to variable and reuse
src/components/TodoComponent.tsx
Outdated
Comment on lines
122
to
130
| onClick={async () => { | ||
| try { | ||
| setIsToLoad(true); | ||
| await onRemoveTodo(todo.id); | ||
| } catch (err) { | ||
| } finally { | ||
| setIsToLoad(false); | ||
| } | ||
| }} |
There was a problem hiding this comment.
move into function looks very complicated
src/components/TodoComponent.tsx
Outdated
Comment on lines
137
to
140
| onSubmit={async e => { | ||
| e.preventDefault(); | ||
| await saveChangesHandler(); | ||
| }} |
There was a problem hiding this comment.
let's this also move into function
StasSokolov1
suggested changes
Jan 7, 2025
src/App.tsx
Outdated
| try { | ||
| setLoadTodo({ | ||
| id: 0, | ||
| title: todoQuery.trim(), |
src/api/todos.ts
Outdated
| }; | ||
|
|
||
| export const addTodo = (todo: Omit<Todo, 'id' | 'userId' | 'completed'>) => { | ||
| return client.post<Todo>(`/todos`, { |
src/components/TodoHeader.tsx
Outdated
| searchInput.current?.focus(); | ||
| }; | ||
|
|
||
| const ToggleAllHandler = async () => { |
There was a problem hiding this comment.
Suggested change
| const ToggleAllHandler = async () => { | |
| const toggleAllHandler = async () => { |
src/components/TodoHeader.tsx
Outdated
Comment on lines
66
to
68
| try { | ||
| await updateCompletedAllToDo(); | ||
| } catch (err) {} |
There was a problem hiding this comment.
why we need try {} catch () {} with empty catch block?
StasSokolov1
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK