make fill take function as value for matrix #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartvanandel
suggested changes
Jan 2, 2017
| data[k] = deviation * Math.random() + mean; | ||
|
|
||
| return Matrix.fromTypedArray(data, [i, j]); | ||
| return Matrix.fill(count, function() { |
There was a problem hiding this comment.
Undefined variable count
bartvanandel
reviewed
Jan 5, 2017
| k; | ||
| for (k = 0; k < size; k++) | ||
| data[k] = value; | ||
| data[k] = (isValueFn && value()) || value; |
There was a problem hiding this comment.
Two issues with this approach.
- When value() returns false, code will try to set data[k] the function instead.
- Value function should probably take (row, col) as input to improve its usability
Summarized, better use something like this:
data[k] = isValueFn ? value(k / j | 0, k % j) : value;
Note: adapted from Matrix.prototype.map which uses same approach for row/col computation.
Side note: for consistency of value names fill should probably use r, c as arguments: i and j are more often used as element indices, not size parameters.
bartvanandel
approved these changes
Jan 9, 2017
|
See changes in #101. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.