Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add nix support #26

Merged
merged 3 commits into from
May 20, 2024
Merged

build: add nix support #26

merged 3 commits into from
May 20, 2024

Conversation

matt1432
Copy link
Contributor

This is a very simple PR to make your project easily available to nix users.

I made it so the builds for nix will automatically pick up the right versions so there is no need for any changes in the future from you.

@mateoradman
Copy link
Owner

mateoradman commented May 19, 2024

Lovely, thanks a lot! Sorry for my lack of understanding of how Nix works 🙂

I have a few questions:

  • Should we add documentation to the README file, or is this installation/build method self-explanatory for Nix users?
  • Also, should I generate and upload Nix builds for every release using a GitHub Action? Do those differ from standard Linux binary executables?

@matt1432
Copy link
Contributor Author

No worries, I enjoy nixifying repos!

  1. The installation is self-explanatory for Nix users because this is just a simple package. As long as the user knows how flakes work, they're fine. Explaining how flakes work is definitely out of the scope of this repo.

  2. Nix binaries do differ from standard Linux ones. There is a way to automate a cache binary but this package is pretty small so it won't be necessary. I could add a github action that checks if the nix build works in a separate PR if you'd like.

@mateoradman
Copy link
Owner

Got it, thanks for the explanation. Merging the PR now.

re 2.: I think that Github Action will not be necessary for now. Thanks anyway!

@mateoradman mateoradman merged commit 109e151 into mateoradman:main May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants