This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
chore: Explicitly reference index.js under MDC packages #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moog16
approved these changes
Sep 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a mix of MDC imports that explicitly reference
index, explicitly referencedist/mdc.*.js, and others that just import the package root.This PR updates so that everything references
index, since I already configured our toolchain to process MDC's code through babel back in #43. It saves roughly 17KB in the minified/gzipped JS produced by the build on master, and will save more in future releases when considering that material-components/material-components-web#3245 will change the behavior of package-root imports.