-
Notifications
You must be signed in to change notification settings - Fork 230
fix(drawer): replace focus trap with vanilla version #437
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Codecov Report
@@ Coverage Diff @@
## rc7.0 #437 +/- ##
==========================================
- Coverage 96.56% 96.56% -0.01%
==========================================
Files 57 57
Lines 1923 1922 -1
Branches 228 228
==========================================
- Hits 1857 1856 -1
Misses 66 66
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in README drawerOnClose
-> onDrawerClose
. otherwise LGTM
CLAs look good, thanks! |
fixes #433