Skip to content
This repository has been archived by the owner on Jan 14, 2025. It is now read-only.

fix(drawer): replace focus trap with vanilla version #437

Merged
merged 5 commits into from
Nov 16, 2018

Conversation

moog16
Copy link

@moog16 moog16 commented Nov 13, 2018

fixes #433

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@moog16 moog16 changed the base branch from master to rc7.0 November 13, 2018 21:30
@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #437 into rc7.0 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            rc7.0     #437      +/-   ##
==========================================
- Coverage   96.56%   96.56%   -0.01%     
==========================================
  Files          57       57              
  Lines        1923     1922       -1     
  Branches      228      228              
==========================================
- Hits         1857     1856       -1     
  Misses         66       66
Impacted Files Coverage Δ
packages/drawer/index.js 97.36% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270357a...f2020c3. Read the comment docs.

Copy link
Contributor

@bonniezhou bonniezhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in README drawerOnClose -> onDrawerClose. otherwise LGTM

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants