Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(button): upgrade to mdcw 2.x #886

Merged
merged 3 commits into from
Jun 11, 2019
Merged

chore(button): upgrade to mdcw 2.x #886

merged 3 commits into from
Jun 11, 2019

Conversation

lucasecdb
Copy link
Contributor

related to #885

@codecov-io
Copy link

codecov-io commented May 26, 2019

Codecov Report

Merging #886 into rc0.14.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           rc0.14.0     #886   +/-   ##
=========================================
  Coverage     94.09%   94.09%           
=========================================
  Files            86       86           
  Lines          3643     3643           
  Branches        574      574           
=========================================
  Hits           3428     3428           
  Misses           90       90           
  Partials        125      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a0cfc...d56c508. Read the comment docs.

@lucasecdb
Copy link
Contributor Author

I think the golden for this needs to be updated, since the border width was fixed in material-components/material-components-web#4606

@moog16 moog16 changed the base branch from rc0.13.0 to rc0.14.0 May 31, 2019 13:21
@moog16
Copy link

moog16 commented Jun 10, 2019

I ran the tests locally and they seemed to pass.

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update golden.json please:

button -> 6cbbd327e41e08dd5bcbf3827addb3bd7bb48e029be11776efcca34c537a00bc
snackbar -> 7fb41a8b47ef506cf37cc962147b88c05706097903befe98e2296680c2007fba

@moog16 moog16 merged commit 4793a48 into material-components:rc0.14.0 Jun 11, 2019
@moog16 moog16 deleted the chore/upgrade-button-2x branch June 11, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants