fix(menusurface): Fixing bug where body click listener is not being p…

…roperly deregistered. closes: #6557 PiperOrigin-RevId: 339893099
material-components · Oct 30, 2020 · cec8587 · cec8587
1 parent 710f97b
commit cec8587
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/mdc-menu-surface/component.ts b/packages/mdc-menu-surface/component.ts
@@ -74,7 +74,8 @@ export class MDCMenuSurface extends MDCComponent<MDCMenuSurfaceFoundation> {
           'click', this.handleBodyClick, {capture: true});
     };
     this.deregisterBodyClickListener = () => {
-      document.body.removeEventListener('click', this.handleBodyClick);
+      document.body.removeEventListener(
+          'click', this.handleBodyClick, {capture: true});
     };
 
     this.listen('keydown', this.handleKeydown);

diff --git a/packages/mdc-menu-surface/test/component.test.ts b/packages/mdc-menu-surface/test/component.test.ts
@@ -168,6 +168,7 @@ describe('MDCMenuSurface', () => {
   it(`${strings.CLOSED_EVENT} causes the body click handler to be deregistered`,
      () => {
        const {root, mockFoundation} = setupTest();
+       emitEvent(root, strings.OPENED_EVENT);
        emitEvent(root, strings.CLOSED_EVENT);
        emitEvent(document.body, 'click');
        expect(mockFoundation.handleBodyClick)