Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make snackbar more resilient to text overflow #11

Closed
traviskaufman opened this issue Dec 5, 2016 · 0 comments · Fixed by #4166
Closed

Make snackbar more resilient to text overflow #11

traviskaufman opened this issue Dec 5, 2016 · 0 comments · Fixed by #4166
Labels
backlog bug

Comments

@traviskaufman
Copy link
Contributor

For a single-line snackbar, we could make it so that the text will not cause line breaks (and show an ellipses instead, perhaps). For multiline, we'd have to trust the user not to put in arbitrarily long strings of text.

Some browsers also support clamping to a certain number of lines, so we can progressively enhance for that as well

Copied from google/material-design-lite#4828
@traviskaufman traviskaufman added this to the Beta milestone Dec 5, 2016
@sfdexter sfdexter mentioned this issue Dec 16, 2016
Closed
@kfranqueiro kfranqueiro removed this from the Beta milestone Oct 4, 2018
@acdvorak acdvorak mentioned this issue Dec 11, 2018
Merged
acdvorak added a commit that referenced this issue Dec 13, 2018
@acdvorak
feat(snackbar): Update to match latest design guidelines (#4166)
33d30e6 
### Issues fixed

* Fixes #4005 (via new `mdc-snackbar-viewport-margin()` mixin)
* Fixes #3981
* Fixes #2916 (via new `MDCSnackbar:closing` and `MDCSnackbar:closed` events)
* Fixes #2628
* Fixes #1466 (via new `close()` method)
* Fixes #1398
* Fixes #1258
* Fixes #11 (the label now expands indefinitely to fit the text)
* Refs #2813

### Screenshots

![Baseline without action button](https://user-images.githubusercontent.com/409245/49956261-a080ca80-feb9-11e8-8287-b7e805344115.png)

![Baseline with action button](https://user-images.githubusercontent.com/409245/49956109-4a138c00-feb9-11e8-9213-3241fa86a1b8.png)

![Stacked layout](https://user-images.githubusercontent.com/409245/49956173-6a434b00-feb9-11e8-8a03-2e58ccc8f763.png)

BREAKING CHANGE: Snackbar's DOM and APIs have changed to match the latest design guidelines. See the Snackbar documentation for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(snackbar): Update to match latest design guidelines material-components/material-components-web
2 participants
@kfranqueiro @traviskaufman