fix(ripple): Revert #1098 to fix bounded ripples #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0f1ca35.
|
I don't suggest reverting, but I do suggest fixing this. |
|
@touficbatache I'm sorry we are reverting this. In the name of efficiency, our team favors quick rollbacks over "fix forward". But I would love for you could create a follow up PR that re-implements the fix to #1067, PLUS a fix for the errors seen here:
|
lynnmercier
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0f1ca35 and fixes #1184.
Unfortunately this commit caused a major regression for bounded ripples, such as those seen in the button and dialog demos.