Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDC Select's scaleX logic is currently unused/overridden #1802

Closed
kfranqueiro opened this issue Dec 19, 2017 · 1 comment
Closed

MDC Select's scaleX logic is currently unused/overridden #1802

kfranqueiro opened this issue Dec 19, 2017 · 1 comment

Comments

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Dec 19, 2017

MDC Select contains code to set transform-origin for the purposes of applying a scaleX transform to the bottom-line element, but it is currently overridden by the scaleY transform in the focused and open states anyway. This means that the JS logic to determine the transform-origin is just wasting resources at the moment.

We should either figure out a way for these transforms to coexist, or remove the excess JS logic that ultimately isn't doing anything.

@lynnmercier
Copy link
Contributor

See #1981 for how we plan on adding the bottom line to MDCSelect...now that we've removed the scaleX logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants