Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): Remove unused JS logic for bottom-line scaleX transform #1910

Merged
merged 7 commits into from
Jan 12, 2018
Merged

fix(select): Remove unused JS logic for bottom-line scaleX transform #1910

merged 7 commits into from
Jan 12, 2018

Conversation

williamernest
Copy link
Contributor

@williamernest williamernest commented Jan 9, 2018 •
edited
Loading

refs: #1802

Removed javascript logic that computed the location of a click for the bottom-line transform because it was not being used.

lynnmercier
lynnmercier approved these changes Jan 11, 2018
View reviewed changes
Copy link
Contributor

@lynnmercier lynnmercier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jan 12, 2018 •
edited
Loading

Codecov Report

Merging #1910 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1910      +/-   ##
==========================================
- Coverage   99.43%   99.43%   -0.01%     
==========================================
  Files          84       84              
  Lines        3721     3710      -11     
  Branches      484      484              
==========================================
- Hits         3700     3689      -11     
  Misses         21       21
Impacted Files Coverage Δ
packages/mdc-select/foundation.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62beff...d7106de. Read the comment docs.

@williamernest williamernest merged commit 82a9fa3 into master Jan 12, 2018
@williamernest williamernest deleted the fix/select/unused-scaleX branch January 12, 2018 22:18
acdvorak added a commit that referenced this pull request Jan 13, 2018
@acdvorak
WIP: Squashed commit of the following:
bf78518 
commit 82a9fa3
Author: Will Ernest <34519388+williamernest@users.noreply.github.com>
Date:   Fri Jan 12 14:18:37 2018 -0800

    fix(select): Remove unused JS logic for bottom-line scaleX transform (#1910)

    fix(select): Remove unused JS logic for bottom-line scaleX transform and matching test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynnmercier lynnmercier lynnmercier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamernest @codecov-io @lynnmercier