-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): reduce adapter apis not used in MDCReact and update events to new pattern #3204
Conversation
🤖 Beep boop! Screenshot test reportCommit 1bc6d77 vs. No diffs! 💯🎉 |
Codecov Report
@@ Coverage Diff @@
## master #3204 +/- ##
==========================================
- Coverage 98.13% 98.12% -0.01%
==========================================
Files 101 101
Lines 4444 4426 -18
Branches 585 585
==========================================
- Hits 4361 4343 -18
Misses 83 83
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It occurred to me this morning that maybe we should also rename setDisabled
on the foundation, since it's not actually doing the setting itself anymore. Maybe updateDisabledStyle
or something?
Also, this will need some BREAKING CHANGE notes when we merge it, e.g.: Removed some adapter APIs and shifted responsibility of event handling and programmatic select
element updates out of the foundation and into the component.
🤖 Beep boop! Screenshot test reportCommit 35dee08 vs. No diffs! 💯🎉 |
🤖 Beep boop! Screenshot test reportCommit 4cf3ffd vs. No diffs! 💯🎉 |
🤖 Beep boop! Screenshot test reportCommit 2004983 vs. No diffs! 💯🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add BREAKING CHANGE: ... to the commit description when merging (see my previous comment)
Will do! |
🤖 Beep boop! Screenshot test reportCommit 793e0f4 vs. No diffs! 💯🎉 |
fixes #3198