Annotate mdc-menu for closure #339
Assignees
Labels
Comments
|
cc @bogusred assigning @lynnjepsen to track |
|
@traviskaufman @lynnjepsen According to the closure style guide, the compiler doesn't have great support for ES6 getters/setters. As part of this task, would you like me to change the getters/setters to regular methods? |
bogusred
added a commit
to bogusred/material-components-web
that referenced
this issue
Jun 16, 2017
…ponents#339) Added new annotations to mdc-menu. Corrected a couple of annotations in base.
|
Hmm I'm not sure...It says "limited support", and we're not doing anything too crazy. Can we leave them as getters/setters for now? And if the compiler actually does start doing odd things we can revisit? My reasoning is I don't really want to spend extra work on something that might not even be a problem. Especially if it takes us away from an ES6 best practice. |
|
Sgtm 👍 |
bogusred
added a commit
to bogusred/material-components-web
that referenced
this issue
Jun 21, 2017
…ts#339) Added new annotations to mdc-menu. Corrected a couple of annotations in base.
bogusred
added a commit
to bogusred/material-components-web
that referenced
this issue
Jun 21, 2017
…ts#339) Added new annotations to mdc-menu. Corrected a couple of annotations in base.
lynnmercier
pushed a commit
that referenced
this issue
Jun 27, 2017
Resolves #339 Added new annotations to mdc-menu. Corrected a couple of annotations in base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: