fix(list): Update ARIA attributes for radio/checkbox based list #4055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
suggested changes
Nov 9, 2018
|
EDIT: role="list" or ul/li (without ‘’listbox’) elements are not supposed
to be keyboard interactive as per ARIA spec. That includes not arrowing
through list.
Fixed typo. Sorry I missed ‘not’ in my previous comment.
…On Thu, Nov 15, 2018 at 3:38 PM Will Ernest ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/mdc-list/README.md
<#4055 (comment)>
:
> @@ -39,7 +39,7 @@ npm install @material/list
### HTML Structure
```html
-<ul class="mdc-list" aria-orientation="vertical">
aria-orienation is used to indicate which arrow keys the foundation
listens to for traversing the list. If we remove this from all ul
examples that are not role="listbox" we need to change the attribute we
use to indicate list direction.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4055 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC40BS9iR3DeYjEFUwMJIRIVdlla2fgks5uvdDCgaJpZM4YPbS0>
.
|
kfranqueiro
reviewed
Nov 20, 2018
kfranqueiro
reviewed
Nov 27, 2018
kfranqueiro
reviewed
Nov 27, 2018
kfranqueiro
reviewed
Nov 28, 2018
Codecov Report
@@ Coverage Diff @@
## master #4055 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 126 126
Lines 5637 5637
Branches 755 755
=======================================
Hits 5545 5545
Misses 92 92
Continue to review full report at Codecov.
|
kfranqueiro
reviewed
Nov 28, 2018
kfranqueiro
reviewed
Nov 28, 2018
kfranqueiro
approved these changes
Nov 28, 2018
|
🤖 Beep boop! Screenshot test report 🚦16 screenshots changed from |
This was referenced Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the aria attributes (
aria-selectedoraria-checked) for single select, checkbox or radio based lists.BREAKING CHANGE: Replaced
toggleCheckboxadapter method withsetCheckedCheckboxOrRadioAtIndexand added 3 more new adapter methods for improved accessibility.Fixes #3659, #3403, #4107