This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(checkbox): change checkbox event type from change to click and add some logic for IE browser #5316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al-components-web into issuefix/4893
candysonya
changed the title
update readme and unit test for newly added methods in adapter and foundation pr #5316
Codecov Report
@@ Coverage Diff @@
## master #5316 +/- ##
==========================================
- Coverage 98.52% 98.32% -0.21%
==========================================
Files 163 163
Lines 6309 6322 +13
Branches 864 866 +2
==========================================
Hits 6216 6216
- Misses 93 106 +13
Continue to review full report at Codecov.
|
bonniezhou
suggested changes
Dec 12, 2019
bonniezhou
suggested changes
Dec 12, 2019
|
All 731 screenshot tests passed for commit 35f81b6 vs. |
bonniezhou
reviewed
Dec 16, 2019
|
All 728 screenshot tests passed for commit 4a4ace4 vs. |
|
@bonniezhou @candysonya Hi, is there a CL for this PR? Merging a PR without a CL would create discrepancies for other PRs until we automate this stuff. If CL is not yet submitted please consider reverting this PR. |
|
Reverting this since it breaks MWC, should sync with internal first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4893
Run some local test.