Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

revert: "fix(checkbox): change checkbox event type from change to click and add some logic for IE browser" #5368

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

allan-chen
Copy link
Collaborator

@allan-chen allan-chen commented Dec 20, 2019

Reverts #5316

Breaks MWC - should update downstream clients and sync to internal first

…k and add some logic for IE browser (#5316)"

This reverts commit 2e491de.
@allan-chen allan-chen changed the title Revert "fix(checkbox): change checkbox event type from change to click and add some logic for IE browser" fix(checkbox): Revert #5316 Dec 20, 2019
@allan-chen allan-chen requested a review from abhiomkar December 20, 2019 00:42
@abhiomkar abhiomkar changed the title fix(checkbox): Revert #5316 revert: "fix(checkbox): change checkbox event type from change to click and add some logic for IE browser" Dec 20, 2019
Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed PR title to revert: "fix(checkbox): change checkbox event type from change to click and add some logic for IE browser" to reflect on Changelog. You can use the same message when you Squash & Merge.

Thanks!

@codecov-io
Copy link

Codecov Report

Merging #5368 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5368      +/-   ##
==========================================
- Coverage   98.44%   98.44%   -0.01%     
==========================================
  Files         163      163              
  Lines        6317     6304      -13     
  Branches      863      861       -2     
==========================================
- Hits         6219     6206      -13     
  Misses         98       98
Impacted Files Coverage Δ
packages/mdc-checkbox/foundation.ts 93.61% <ø> (-0.73%) ⬇️
packages/mdc-checkbox/component.ts 96.73% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ae6e1...574d2c7. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 728 screenshot tests passed for commit 574d2c7 vs. master! 💯🎉

@allan-chen allan-chen merged commit ba30399 into master Dec 20, 2019
@allan-chen allan-chen deleted the revert-5316-issuefix/4893 branch December 20, 2019 01:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants