Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

[DataTable] example code of DataTable #5483

Closed
jony666666 opened this issue Jan 17, 2020 · 2 comments
Closed

[DataTable] example code of DataTable #5483

jony666666 opened this issue Jan 17, 2020 · 2 comments
Labels
backlog docs help wanted

Comments

@jony666666
Copy link
Contributor

jony666666 commented Jan 17, 2020 •
edited
Loading

Bug report

Steps to reproduce

  1. Go to '/material-components-web/packages/mdc-data-table/'
  2. Click on 'README.md'
  3. Scroll down to 'Variants:Data table with row selection'
  4. See error at <svg class="mdc-checkbox__checkmark" viewbox="0 0 24 24">

Actual behavior

the viewbox attribute dosen't work , the style of checkbox is broken .

Your Environment:

Software Version(s)
MDC Web -
Browser Safari 13.04/FireFox 72.0.1
Operating System macOS 10.15.2

Additional context

Webpack/SASS/Vue

Possible solution

this svg attribute seems to be case-sensitive, i replaced viewbox with viewBox and solved it.
@jony666666 jony666666 added the bug label Jan 17, 2020
@asyncLiz
Copy link
Contributor

Thanks for the issue! Looks like it also needs to be updated in the component test.

Would you be willing to open a PR to fix it?

jony666666 pushed a commit to jony666666/material-components-web that referenced this issue Jan 18, 2020
fix(data-table): change svg attribute name viewbox to viewBox (materi…
27c5fd2 
…al-components#5483)
jony666666 added a commit to jony666666/material-components-web that referenced this issue Jan 18, 2020
@jony666666
fix(data-table): change svg attribute name viewbox to viewBox (materi…
6a56491 
…al-components#5483)
asyncLiz pushed a commit that referenced this issue Jan 28, 2020
@jony666666 @asyncLiz
fix(data-table): change svg attribute name viewbox to viewBox (#5483) (…
f3adce8 
…#5493)
@asyncLiz
Copy link
Contributor

Fixed in #5493

This was referenced Feb 13, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this issue Mar 7, 2020
Open
@adrianschmidt adrianschmidt mentioned this issue Dec 10, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
backlog docs help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asyncLiz @jony666666