Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-table): change svg attribute name viewbox to viewBox (#5483) #5493

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

jony666666
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you also update component.ts:51?

@asyncLiz
Copy link
Contributor

@jony666666 any update on adding the fix for the other instance of this typo?

@jony666666
Copy link
Contributor Author

@jony666666 any update on adding the fix for the other instance of this typo?

I searched the whole project code and didn't find the other instance of this typo.

@jony666666
Copy link
Contributor Author

Thanks for the PR! Can you also update component.ts:51?

I created a new PR for it. I don't have much experience of using Github,I don't know if this is a good way.

@asyncLiz
Copy link
Contributor

No worries @jony666666, it actually looks like you updated this PR as well.

For the future, all you need to do is create a new commit with more changes and push it to your branch. The PR will automatically update. 😊

@asyncLiz asyncLiz merged commit f3adce8 into material-components:master Jan 28, 2020
@jony666666
Copy link
Contributor Author

No worries @jony666666, it actually looks like you updated this PR as well.

For the future, all you need to do is create a new commit with more changes and push it to your branch. The PR will automatically update. 😊

ok , thank you!

copybara-service bot pushed a commit that referenced this pull request Feb 4, 2020
Tested:
  TODO
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5493 from jony666666:master 6a56491
PiperOrigin-RevId: 291252380
copybara-service bot pushed a commit that referenced this pull request Feb 4, 2020
This is a long description of button comment changes.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#5493 from jony666666:master 6a56491
PiperOrigin-RevId: 291252380
copybara-service bot pushed a commit that referenced this pull request Feb 5, 2020
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5493 from jony666666:master 6a56491
PiperOrigin-RevId: 293228410
copybara-service bot pushed a commit that referenced this pull request Feb 5, 2020
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5493 from jony666666:master 6a56491
PiperOrigin-RevId: 293228410
copybara-service bot pushed a commit that referenced this pull request Feb 5, 2020
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5493 from jony666666:master 6a56491
PiperOrigin-RevId: 293466751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants