-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(data-table): change svg attribute name viewbox to viewBox (#5483) #5493
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Can you also update component.ts:51?
@jony666666 any update on adding the fix for the other instance of this typo? |
I searched the whole project code and didn't find the other instance of this typo. |
I created a new PR for it. I don't have much experience of using Github,I don't know if this is a good way. |
No worries @jony666666, it actually looks like you updated this PR as well. For the future, all you need to do is create a new commit with more changes and push it to your branch. The PR will automatically update. 😊 |
ok , thank you! |
No description provided.