-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDCSelect] Setting value causes change event to be fired twice #5570
Comments
Hi - Thanks for reaching out. I was able to reproduce this on the given fiddle. It seems like in the foundation code, |
Previously `handleChange()` was called both in `setSelectedIndex()` and in `setValue()` which calls `setSelectedIndex()`. Closes #5570 PiperOrigin-RevId: 297416198
Previously `handleChange()` was called both in `setSelectedIndex()` and in `setValue()` which calls `setSelectedIndex()`. Closes #5570 PiperOrigin-RevId: 297416198
Previously `handleChange()` was called both in `setSelectedIndex()` and in `setValue()` which calls `setSelectedIndex()`. Closes #5570 PiperOrigin-RevId: 297416198
This still appears to be an issue in the 5.1.0 release |
Looks like this missed the 5.1.0 release by a day - should be out next release |
@allan-chen Do you know when the next version will be available via NPM to take advantage of the correction ? |
Bug report
Setting the selected option of an MDCSelect element by setting the value causes the change event to be fired twice.
Steps to reproduce
Actual behavior
The change event is fired twice.
Expected behavior
The change event should only be fired once.
Your Environment:
Additional context
I've created a JSFiddle showing the issue here:
https://jsfiddle.net/1q09hsc2/7/
The text was updated successfully, but these errors were encountered: