Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDC Circular Progress] Circular Progress not displayed correctly inside button #6388

Closed
maicol07 opened this issue Aug 14, 2020 · 3 comments · Fixed by #6389
Closed

[MDC Circular Progress] Circular Progress not displayed correctly inside button #6388

maicol07 opened this issue Aug 14, 2020 · 3 comments · Fixed by #6389

Comments

@maicol07
Copy link

Bug report

Circular progress not displayed correctly

Steps to reproduce

  1. Create a button
  2. Create a circular progress inside button

Actual behavior

See codepen: https://codepen.io/maicol07/pen/QWNNwxO

Expected behavior

Circular Progress displayed correctly

Your Environment:

Software Version(s)
MDC Web 7.0.0
Browser Firefox
Operating System Windows 10
@maicol07 maicol07 added the bug label Aug 14, 2020
@joyzhong
Copy link
Contributor

Thanks for reporting this issue! Can you clarify your use case for using a circular progress indicator inside of a button?

@maicol07
Copy link
Author

@joyzhong sure.
I'm using a circular progress isnide a button to show a loading button. When a user clicks on it, an AJAX request is sent to the server. Meanwhile, the button is loading

@joyzhong
Copy link
Contributor

joyzhong commented Aug 14, 2020

Got it! This pattern is demonstrated in the MD spec: "A circular indicator can be integrated into a button or actionable icon to express a connection between an interaction and a specific item. They are typically used to express when an interaction, such as clicking a button again, isn’t available."

Adding to our backlog.

+cc @allan-chen

copybara-service bot pushed a commit that referenced this issue Aug 14, 2020
For real this time.
closes #6388

PiperOrigin-RevId: 326683559
copybara-service bot pushed a commit that referenced this issue Aug 14, 2020
For real this time.
closes #6388

PiperOrigin-RevId: 326683559
copybara-service bot pushed a commit that referenced this issue Aug 17, 2020
For real this time.
closes #6388

PiperOrigin-RevId: 326683559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants