Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List end detail has a wrong padding #904

Closed
touficbatache opened this issue Jul 5, 2017 · 2 comments · Fixed by #909
Closed

List end detail has a wrong padding #904

touficbatache opened this issue Jul 5, 2017 · 2 comments · Fixed by #909
Labels
help wanted

Comments

@touficbatache
Copy link
Contributor

touficbatache commented Jul 5, 2017 •
edited
Loading

Bugs

What MDC-Web Version are you using?

0.14.0

What browser(s) is this bug affecting?

All browsers

What OS are you using?

All OS

What are the steps to reproduce the bug?

  1. Go to http://material-components-web.appspot.com/list.html
  2. Scroll down to the End Detail section
  3. Observe the end detail item's location

What is the expected behavior?

The end detail item should be 16px away from the end of the list

What is the actual behavior?

The end detail item should be 32px away from the end of the list

Any other information you believe would be useful?

This could easily be fixed by removing the margin-right: 16px from the mdc-list-item__end-detail class as the mdc-list class already has a padding of 16px on the right. Would you like a PR?
@amsheehan
Copy link
Contributor

Yes please! Good catch.

@touficbatache touficbatache mentioned this issue Jul 6, 2017
Merged
@touficbatache
Copy link
Contributor Author

Done 😃

yeelan0319 pushed a commit that referenced this issue Jul 13, 2017
@touficbatache @yeelan0319
fix(list): Correct list end detail padding (#909)
d7aa726 
Closes #904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(list): List end detail has a wrong padding
2 participants
@amsheehan @touficbatache