demo(text-field): Move script into head #1636
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1636 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 72 72
Lines 3439 3439
Branches 420 420
=======================================
Hits 3426 3426
Misses 13 13Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Could you possibly create an issue for this?
I've never encountered that error, so I'd be curious to know:
- How often you see the error
- Which version of MDC-Web you're using
- Which devices, OS versions, browser versions, etc. it occurs in
- Whether it occurs more frequently when you're on a slow network or a slow device
- Whether you see the same error on other demo pages
- What the line number and stack trace are
- What the repro steps are
(Please include the above in the issue.)
Presumably this kind of error is not specific to text field, and could just as easily happen to any other demo. If it repros reliably, we would want to apply a fix to all of our demo pages.
Also, I'm not sure that moving the <script> tag up into <head> is the right fix. It would be good to know why the error is happening in the first place. All of our <script> tags are blocking, synchronous, and evaluated sequentially, so unless Webpack is doing some funky setTimeout/requestAnimationFrame nonsense, I don't see why the error should even be possible.
|
I filed an issue, #1808, because I was able to reproduce this quite quickly on our main demo site. But it we should not merge this PR until we know what the root cause of the issue is. @anton-kachurin do you know why this is happening in the first place? |
This removes the console error message caused by scripts trying to use the global variable
mdcbefore it was created:text-field.html:184 Uncaught ReferenceError: mdc is not defined