chore(select): Fix JS example to actually work #2332

williamernest · 2018-03-01T21:28:19Z

Refs: #2275
Doesn't fix the entire README, which needs to be redone, but it does fix our JS example to actually run until we get to it.

moog16 · 2018-03-01T22:08:55Z

packages/mdc-select/README.md

@@ -80,7 +80,7 @@ Then with JS
 ```js
 import {MDCSelect} from '@material/select';


should we also then remove this?

Yes, but this readme doesn't ever reference the Importing the JS component section, so I'll add that under this code block.

moog16 · 2018-03-01T22:09:02Z

packages/mdc-select/README.md

@@ -80,7 +80,7 @@ Then with JS
 ```js
 import {MDCSelect} from '@material/select';


should we also then remove this?

Yes, but this readme doesn't ever reference the Importing the JS component section, so I'll add that under this code block.

moog16 · 2018-03-01T22:15:12Z

packages/mdc-floating-label/mdc-floating-label.scss

@@ -29,6 +29,7 @@
  transform-origin: left top;
  transition: mdc-floating-label-transition(transform), mdc-floating-label-transition(color);
  cursor: text;
+  will-change: transform;


does this fix the jitter?

moog16

LGTM

codecov-io · 2018-03-01T22:29:45Z

Codecov Report

Merging #2332 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2332   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         100      100           
  Lines        4118     4118           
  Branches      527      527           
=======================================
  Hits         4071     4071           
  Misses         47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc17291...bd91496. Read the comment docs.

kfranqueiro · 2018-03-02T18:37:15Z

This seems reasonable given that we have other READMEs that do the same, but we currently have inconsistency in whether we reference the globals or use syntax that assumes ES6 imports. We should standardize on one or the other eventually.

@alternate

commit f17e0d3 Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Thu Mar 8 13:20:48 2018 -0500 fix(text-field): Clicking label should focus textfield (#2353) commit 77b15f4 Author: Bonnie Zhou <bzbee003@gmail.com> Date: Wed Mar 7 16:29:57 2018 -0800 refactor(button): Remove compact variant (#2361) BREAKING CHANGE: The compact variant of MDC Button is removed. commit 35a5cfc Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Tue Mar 6 19:54:23 2018 -0500 fix(toolbar): Fix colors for svg icons. Update custom-toolbar demo (#2331) SVG icons in the toolbar will now use the same color as the font icons. commit dc52201 Author: Andrew C. Dvorak <acdvorak@gmail.com> Date: Tue Mar 6 16:00:12 2018 -0800 fix(theme): Move @alternate annotations for Closure Stylesheets (#2355) `@alternate` annotations need to come before the _second_ property. Otherwise, Closure Compiler strips the first property (it does not output it at all). commit 3c04419 Author: aprigogin <17075403+aprigogin@users.noreply.github.com> Date: Tue Mar 6 14:29:12 2018 -0800 fix(button): icon in rtl should have margin right flipped. (#2346) commit b9000a4 Author: Cory Reed <swashcap@gmail.com> Date: Tue Mar 6 07:37:40 2018 -0800 fix(demos): Correct RTL/LTR toggling in demos in Safari (#2348) commit ab85736 Author: Andrew C. Dvorak <acdvorak@gmail.com> Date: Mon Mar 5 19:00:11 2018 -0500 fix: Use `var` instead of `const` in menu demo (#2345) Safari 9.x and IE 10 do not support `const` commit dc3d69f Author: aprigogin <17075403+aprigogin@users.noreply.github.com> Date: Mon Mar 5 15:22:31 2018 -0800 fix(rtl): Adding noflip annotations to fix downstream rtl issues (#2344) * fix(rtl): Adding noflip annotations to fix downstream rtl issues * fix(rtl): remove changes to button, will be in separate PR * fix(rtl): remove changes to button, will be in separate PR - second attempt. * fix(rtl): removed extra whitespace commit eb4138e Author: Patrick RoDee <prodee@google.com> Date: Mon Mar 5 14:10:46 2018 -0800 docs: Update CHANGELOG.md commit f478610 Author: Patrick RoDee <prodee@google.com> Date: Mon Mar 5 14:10:30 2018 -0800 chore: Publish commit 78408bb Author: Andrew C. Dvorak <acdvorak@gmail.com> Date: Mon Mar 5 16:13:02 2018 -0500 fix: Use `var` instead of `const` in demos/ready.js (#2343) Safari 9.x and IE 10 do not support `const`, and `ready.js` is not transpiled to ES5. commit 49a9449 Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Mon Mar 5 12:21:54 2018 -0500 chore(select): Fix JS example in Readme (#2332) commit bc17291 Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Fri Mar 2 13:21:07 2018 -0500 feat(top app bar): Add short top app bar always collapsed feature (#2327) commit 0ba7d10 Author: Matty Goo <mattgoo@google.com> Date: Fri Mar 2 11:33:19 2018 -0500 fix(text-field): disable validation check in setRequired (#2201) BREAKING CHANGE: removed setRequired and isRequired from foundation. commit c14d244 Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Fri Mar 2 10:37:18 2018 -0500 chore(select): Fix ID values in demo (#2330) Remove unused ID and changed duplicated ID values. Also fixed the parentheses in RTL. commit ecf4060 Author: Bonnie Zhou <bzbee003@gmail.com> Date: Thu Mar 1 16:38:41 2018 -0500 feat(chips): Change chip color when selected (#2329) BREAKING CHANGE: The `mdc-chip--activated` class, `mdc-chip-activated-ink-color` Sass mixin, and the `toggleActive` methods on `MDCChip`/`MDCChipSet` have been renamed to `mdc-chip--selected`, `mdc-chip-selected-ink-color`, and `toggleSelected`, respectively. commit 4b24b51 Author: Matty Goo <mattgoo@google.com> Date: Wed Feb 28 15:20:19 2018 -0500 chore(floating-label): separate label module from text-field (#2237) BREAKING CHANGE: must use `.mdc-floating-label` selector instead of `.mdc-text-field__label` commit fd8d8d9 Author: Will Ernest <34519388+williamernest@users.noreply.github.com> Date: Wed Feb 28 14:21:55 2018 -0500 feat(top-app-bar): Implement short top app bar (#2290) Adds the short top app bar variant to the top app bar. commit a9f9bf2 Author: Kenneth G. Franqueiro <kfranqueiro@users.noreply.github.com> Date: Wed Feb 28 13:06:41 2018 -0500 docs(select): Fix front matter for label sub-component (#2323)

chore(select): Fix JS example to actually work

b4d58ae

williamernest assigned moog16 Mar 1, 2018

moog16 reviewed Mar 1, 2018

View reviewed changes

chore(select): Update readme

3ac5cca

williamernest force-pushed the chore/select/minor-tweak-readme branch from f146ba2 to 3ac5cca Compare March 1, 2018 22:17

moog16 approved these changes Mar 1, 2018

View reviewed changes

Merge branch 'master' into chore/select/minor-tweak-readme

6b503ba

williamernest requested a review from kfranqueiro March 2, 2018 18:25

kfranqueiro approved these changes Mar 2, 2018

View reviewed changes

Merge branch 'master' into chore/select/minor-tweak-readme

bd91496

williamernest merged commit 49a9449 into master Mar 5, 2018

williamernest deleted the chore/select/minor-tweak-readme branch March 5, 2018 17:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(select): Fix JS example to actually work #2332

chore(select): Fix JS example to actually work #2332

williamernest commented Mar 1, 2018

moog16 Mar 1, 2018

williamernest Mar 1, 2018

moog16 Mar 1, 2018

williamernest Mar 1, 2018

moog16 Mar 1, 2018

moog16 left a comment

codecov-io commented Mar 1, 2018 •

edited

Loading

kfranqueiro commented Mar 2, 2018

		@@ -80,7 +80,7 @@ Then with JS
		```js
		import {MDCSelect} from '@material/select';

chore(select): Fix JS example to actually work #2332

chore(select): Fix JS example to actually work #2332

Conversation

williamernest commented Mar 1, 2018

moog16 Mar 1, 2018

Choose a reason for hiding this comment

williamernest Mar 1, 2018

Choose a reason for hiding this comment

moog16 Mar 1, 2018

Choose a reason for hiding this comment

williamernest Mar 1, 2018

Choose a reason for hiding this comment

moog16 Mar 1, 2018

Choose a reason for hiding this comment

moog16 left a comment

Choose a reason for hiding this comment

codecov-io commented Mar 1, 2018 • edited Loading

Codecov Report

kfranqueiro commented Mar 2, 2018

codecov-io commented Mar 1, 2018 •

edited

Loading