Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use var instead of const in menu demo #2345

Merged
merged 3 commits into from
Mar 6, 2018
Merged

fix: Use var instead of const in menu demo #2345

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eb19c5
fix: Use `var` instead of `const` in menu demo
acdvorak Mar 5, 2018
e6e267a
WIP: Fix indentation
acdvorak Mar 5, 2018
1683d13
Merge branch 'master' into fix/demo/menu-compat
acdvorak Mar 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions demos/menu.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,25 +320,25 @@
});
}

const marginInputsEl = document.querySelector('#margin-inputs');
var marginInputsEl = document.querySelector('#margin-inputs');
var inputs = marginInputsEl.querySelectorAll('input[type="text"]');
for (var i = 0; i < inputs.length; i++) {
inputs[i].addEventListener('change', function(evt) {
const topMarginInput = document.getElementById('top-margin');
const bottomMarginInput = document.getElementById('bottom-margin');
const rightMarginInput = document.getElementById('right-margin');
const leftMarginInput = document.getElementById('left-margin');
const margin = {top: parseInt(topMarginInput.value, 10),
right: parseInt(rightMarginInput.value, 10),
bottom: parseInt(bottomMarginInput.value, 10),
left: parseInt(leftMarginInput.value, 10)};
var topMarginInput = document.getElementById('top-margin');
var bottomMarginInput = document.getElementById('bottom-margin');
var rightMarginInput = document.getElementById('right-margin');
var leftMarginInput = document.getElementById('left-margin');
var margin = {top: parseInt(topMarginInput.value, 10),
right: parseInt(rightMarginInput.value, 10),
bottom: parseInt(bottomMarginInput.value, 10),
left: parseInt(leftMarginInput.value, 10)};
menu.setAnchorMargin(margin);
});
}

const rtl = document.querySelector('input[name="is-rtl"]');
var rtl = document.querySelector('input[name="is-rtl"]');
rtl.addEventListener('change', function() {
const demoWrapper = document.getElementById('demo-wrapper');
var demoWrapper = document.getElementById('demo-wrapper');
if (rtl.checked) {
demoWrapper.setAttribute('dir', 'rtl');
} else {
Expand Down