Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

chore: update node-sass, now that it works with node 8 #2408

Merged
merged 5 commits into from
Mar 15, 2018
Merged

chore: update node-sass, now that it works with node 8 #2408

merged 5 commits into from
Mar 15, 2018

Conversation

lynnmercier
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 15, 2018 •
edited
Loading

Codecov Report

Merging #2408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2408   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files         100      100           
  Lines        4144     4144           
  Branches      535      535           
=======================================
  Hits         4098     4098           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea9de6...cc8ac49. Read the comment docs.

kfranqueiro
kfranqueiro suggested changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@kfranqueiro kfranqueiro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, Travis CI can pass with node 8 finally?!

package.json
@@ -73,7 +73,7 @@
"lolex": "2.1.3",
"mkdirp": "^0.5.1",
"mocha": "^5.0.0",
"node-sass": "^4.0.0",
"node-sass": "^4.7.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update package-lock?

Also, is there a reason this is set at 4.7.2 rather than the latest it will match (4.8.2)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated package-lock. 4.7.2 is the most recent release of node-sass on NPM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Yeah just double-checked and 4.8.0 and 4.8.2 on github are marked as pre-release. 4.8.1 oddly isn't. Dunno what's up there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thanks man 👍

@lynnmercier lynnmercier merged commit c2eb537 into master Mar 15, 2018
@lynnmercier lynnmercier deleted the test/node89 branch March 15, 2018 18:04
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 20, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@patrickrodee patrickrodee patrickrodee left review comments

@kfranqueiro kfranqueiro kfranqueiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lynnmercier @codecov-io @kfranqueiro @patrickrodee