This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat(chips): Add mdc-chip-icon-color mixin #2477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/mdc-chips/README.md
Outdated
| @@ -133,7 +133,8 @@ Mixin | Description | |||
| `mdc-chip-corner-radius($radius)` | Customizes the corner radius for a chip | |||
| `mdc-chip-fill-color-accessible($color)` | Customizes the background fill color for a chip, and updates the chip's ink and ripple color to meet accessibility standards | |||
| `mdc-chip-fill-color($color)` | Customizes the background fill color for a chip | |||
| `mdc-chip-ink-color($color)` | Customizes the text ink color for a chip, and updates the chip's ripple color to match | |||
| `mdc-chip-ink-color($color)` | Customizes the text ink color for a chip, and updates the chip's ripple color to match. This affects both text and icon, unless `mdc-chip-icon-color` is also used. | |||
| `mdc-chip-icon-color($color)` | Customizes the icon color for a chip | |||
Codecov Report
@@ Coverage Diff @@
## master #2477 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 104 104
Lines 4234 4234
Branches 534 534
=======================================
Hits 4188 4188
Misses 46 46Continue to review full report at Codecov.
|
|
Potentially a fix to #2484, but waiting on designers to confirm if trailing and leading icons should be customizable separately |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.