Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(switch): Fix switch toggling on IE and Edge #3119

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

rlfriedman
Copy link
Contributor

Fixes #3111, tested in Chrome, Firefox, IE, and Edge. The issue seems to have come from some sort of interaction between the display flex on the parent of the thumb and the rest of the styling (for IE and Edge).

@codecov-io
Copy link

codecov-io commented Jul 17, 2018

Codecov Report

Merging #3119 into feat/switch-update will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/switch-update    #3119   +/-   ##
===================================================
  Coverage               98.49%   98.49%           
===================================================
  Files                     101      101           
  Lines                    4316     4316           
  Branches                  540      540           
===================================================
  Hits                     4251     4251           
  Misses                     65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e071d07...784c52b. Read the comment docs.

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: why is the z-index: 1 needed on __thumb? If I remove that and do nothing else, this problem seems to go away. I'm not sure if that causes any other problems...?

@rlfriedman
Copy link
Contributor Author

z-index: 1 is needed to position the thumb above the ripple underlay.

@kfranqueiro
Copy link
Contributor

Oh, because ripple typically acts as an overlay. Did design specifically indicate that the ripple is supposed to appear in back of the thumb for switch?

I'd check with them first to make sure we're doing the right thing, but otherwise I'll approve this if that's correct.

@rlfriedman
Copy link
Contributor Author

Yeah, I confirmed with design that for switch the ripple should be under the thumb.

@rlfriedman rlfriedman merged commit 235b132 into feat/switch-update Jul 18, 2018
@rlfriedman rlfriedman deleted the fix/switch-ie-edge branch July 19, 2018 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants