Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(infrastructure): Fail builds/tests on non-zero exit codes #3211

Merged
merged 1 commit into from
Jul 25, 2018
Merged

chore(infrastructure): Fail builds/tests on non-zero exit codes #3211

merged 1 commit into from
Jul 25, 2018

Conversation

acdvorak
Copy link
Contributor 

npm run screenshot:test

image

image

@acdvorak acdvorak requested a review from kfranqueiro July 25, 2018 17:58
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report

Commit 4ac769c vs. master:

No diffs! 💯🎉

@codecov-io
Copy link

codecov-io commented Jul 25, 2018 •
edited
Loading

Codecov Report

Merging #3211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3211   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         101      101           
  Lines        4444     4444           
  Branches      585      585           
=======================================
  Hits         4361     4361           
  Misses         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92778e1...4ac769c. Read the comment docs.

kfranqueiro
kfranqueiro approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that a borked PR from a fork now fails CI.

@acdvorak acdvorak merged commit 715f2c5 into master Jul 25, 2018
@acdvorak acdvorak deleted the chore/infra/fail-on-non-zero-exit-codes branch July 25, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfranqueiro kfranqueiro kfranqueiro approved these changes

Assignees

@kfranqueiro kfranqueiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdvorak @mdc-web-bot @codecov-io @kfranqueiro