Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(infrastructure): Render important info in bold in log output #3499

Merged
merged 2 commits into from
Sep 2, 2018
Merged

chore(infrastructure): Render important info in bold in log output #3499

merged 2 commits into from
Sep 2, 2018

Conversation

acdvorak
Copy link
Contributor

@acdvorak acdvorak commented Sep 2, 2018 •
edited
Loading

What it does

  • Colorizes log output:
    • URL params: dimmer
    • User agent alias: bold + italic
    • Image dimensions: bold
  • Changes FAILED to ERROR (shown when an error is thrown during a Selenium session)
  • Refactors SeleniumApi.takeScreenshotWithRetries_() into logRetry_()

Example output

Before:

screenshot of terminal with this PR

After:

screenshot of terminal with this PR

@acdvorak
chore(infrastructure): Render important info in bold in log output
dc9fbdc 
### What it does

- Colorizes log output:
    - URL params: dimmer
    - User agent alias: bold + italic
    - Image dimensions: bold
- Refactors `SeleniumApi.takeScreenshotWithRetries_()`

### Example output

#### After:

![screenshot of terminal with this PR](https://user-images.githubusercontent.com/409245/44960715-07edae00-aeb9-11e8-87f0-8eb78e2cc9fb.png)
acdvorak added a commit that referenced this pull request Sep 2, 2018
@acdvorak
WIP: Remove changes (moved to PR #3499)
f85f4c9
@mdc-web-bot
Copy link
Collaborator

All 357 screenshot tests passed for commit a098097 vs. master! 💯🎉

@acdvorak acdvorak merged commit 95b6b92 into master Sep 2, 2018
@acdvorak acdvorak deleted the chore/infra/logging-color branch September 2, 2018 22:01
adrianschmidt pushed a commit to Lundalogik/material-components-web that referenced this pull request Sep 25, 2018
@acdvorak @williamernest
chore(infrastructure): Render important info in bold in log output (m…
92fa06f 
…aterial-components#3499)

### What it does

- Colorizes log output:
    - URL params: dimmer
    - User agent alias: bold + italic
    - Image dimensions: bold
- Changes `FAILED` to `ERROR` (shown when an error is thrown during a Selenium session)
- Refactors `SeleniumApi.takeScreenshotWithRetries_()` into `logRetry_()`

### Example output

#### Before:

![screenshot of terminal with this PR](https://user-images.githubusercontent.com/409245/44960784-5cddf400-aeba-11e8-8597-f023e790e095.png)

#### After:

![screenshot of terminal with this PR](https://user-images.githubusercontent.com/409245/44960715-07edae00-aeb9-11e8-87f0-8eb78e2cc9fb.png)

(cherry picked from commit 95b6b92)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdc-web-bot mdc-web-bot mdc-web-bot approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acdvorak @mdc-web-bot @googlebot