docs(checkbox): Fix indeterminate button in JS checkbox demo #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@traviskaufman Shouldn't be MDCCheckbox instance 'indeterminate' setter used instead? |
|
@anton-kachurin definitely :) Obviously I rushed this PR out. Nice catch! |
amsheehan
approved these changes
Mar 3, 2017
demos/checkbox.html
Outdated
| document.getElementById('make-ind').addEventListener('click', function() { | ||
| checkbox.indeterminate = true; | ||
| nativeCheckbox.indeterminate = true; |
There was a problem hiding this comment.
Should use setter for instance of MDCheckbox.
Other than that LGTM
The "Make Indeterminate" button in the JS checkbox demo is currently not working because the "indeterminate" property is being set on the checkbox _root_ element, rather than the native instance. This commit fixes that. Skipping TravisCI as this is a change to the demo only. [ci skip]
traviskaufman
force-pushed
the
docs/checkbox-demo-fix
branch
from
1e3aea3 to
188626a
Compare
cristobalchao
pushed a commit
that referenced
this pull request
Mar 14, 2017
The "Make Indeterminate" button in the JS checkbox demo is currently not working because the "indeterminate" property is being set on the checkbox _root_ element, rather than the native instance. This commit fixes that. Skipping TravisCI as this is a change to the demo only. [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Make Indeterminate" button in the JS checkbox demo is currently not
working because the "indeterminate" property is being set on the
checkbox root element, rather than the native instance. This commit
fixes that.
Skipping TravisCI as this is a change to the demo only.
[ci skip]