Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(floating-label): Convert JS to TypeScript #4374

Merged
merged 4 commits into from
Feb 8, 2019
Merged

feat(floating-label): Convert JS to TypeScript #4374

merged 4 commits into from
Feb 8, 2019

Conversation

acdvorak
Copy link
Contributor

@acdvorak acdvorak commented Feb 8, 2019

Refs #4225

@kfranqueiro kfranqueiro mentioned this pull request Feb 8, 2019
Closed
45 tasks
@codecov-io
Copy link

codecov-io commented Feb 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (feat/typescript@77e8bab). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             feat/typescript    #4374   +/-   ##
==================================================
  Coverage                   ?   98.64%           
==================================================
  Files                      ?       93           
  Lines                      ?     5903           
  Branches                   ?      793           
==================================================
  Hits                       ?     5823           
  Misses                     ?       79           
  Partials                   ?        1
Impacted Files Coverage Δ
packages/mdc-floating-label/index.ts 100% <100%> (ø)
packages/mdc-floating-label/foundation.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e8bab...839c5b1. Read the comment docs.

@acdvorak acdvorak mentioned this pull request Feb 8, 2019
Merged
@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 305f82b vs. feat/typescript! 💯🎉

@acdvorak acdvorak mentioned this pull request Feb 8, 2019
Merged
kfranqueiro
kfranqueiro reviewed Feb 8, 2019
View reviewed changes
packages/mdc-floating-label/adapter.ts Outdated Show resolved Hide resolved
packages/mdc-floating-label/foundation.ts Outdated Show resolved Hide resolved
moog16
moog16 suggested changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comments as @kfranqueiro

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit e080877 vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 6ffed95 vs. feat/typescript! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 621 screenshot tests passed for commit 839c5b1 vs. feat/typescript! 💯🎉

@acdvorak acdvorak merged commit 5407ada into feat/typescript Feb 8, 2019
@acdvorak acdvorak deleted the feat/typescript--floating-label branch February 8, 2019 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kfranqueiro kfranqueiro kfranqueiro left review comments

@moog16 moog16 moog16 approved these changes

Assignees

@kfranqueiro kfranqueiro

@moog16 moog16

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acdvorak @codecov-io @mdc-web-bot @kfranqueiro @moog16 @googlebot