This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
feat(tab): Convert JS to TypeScript #4393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdvorak
commented
Feb 9, 2019
45 tasks
Codecov Report
@@ Coverage Diff @@
## feat/typescript #4393 +/- ##
===================================================
+ Coverage 98.65% 98.67% +0.01%
===================================================
Files 94 94
Lines 5962 5972 +10
Branches 803 804 +1
===================================================
+ Hits 5882 5893 +11
+ Misses 79 78 -1
Partials 1 1
Continue to review full report at Codecov.
|
…/material-components-web into feat/typescript--tab
|
are there supposed to be other commits? Not much for the tab package in this PR. |
|
Woops, looks like I missed some Closure syntax in the README. Fixed. |
|
oh thanks for catching that I haven't been checking the readmes |
moog16
suggested changes
Feb 11, 2019
moog16
approved these changes
Feb 11, 2019
|
All 624 screenshot tests passed for commit 8fd2a0e vs. |
|
All 624 screenshot tests passed for commit 53da022 vs. |
|
All 624 screenshot tests passed for commit 8181828 vs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #4225