Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab): Fix tab color variables to use color literals #4688

Merged
merged 2 commits into from
May 9, 2019

Conversation

abhiomkar
Copy link
Collaborator

This should fix #4686 to some extent.

  • Used theme literal (primary) when defining override variables, where as, mdc-theme-prop-value is a function that returns a color value of primary.
  • Set !default to all sass variables defined in _variable.scss for full customization.

@mdc-web-bot
Copy link
Collaborator

All 645 screenshot tests passed for commit a5d63a9 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 645 screenshot tests passed for commit a5d63a9 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 645 screenshot tests passed for commit a60fb4f vs. master! 💯🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: CSS runtime variable theming for tabs is broken
4 participants