-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chips): Add keyboard navigation #4844
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4844 +/- ##
===========================================
+ Coverage 98.86% 98.91% +0.05%
===========================================
Files 119 119
Lines 5650 5822 +172
Branches 749 778 +29
===========================================
+ Hits 5586 5759 +173
+ Misses 63 62 -1
Partials 1 1
Continue to review full report at Codecov.
|
🤖 Beep boop! Screenshot test report 🚦2 screenshots changed from Details2 Changed: |
🤖 Beep boop! Screenshot test report 🚦2 screenshots changed from Details2 Changed: |
🤖 Beep boop! Screenshot test report 🚦2 screenshots changed from Details2 Changed: |
🤖 Beep boop! Screenshot test report 🚦2 screenshots changed from Details2 Changed: |
🤖 Beep boop! Screenshot test report 🚦2 screenshots changed from Details2 Changed: |
🤖 Beep boop! Screenshot test report 🚦2 screenshots changed from Details2 Changed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, left few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a minor bug in the screenshot demos where pressing Right Arrow when on the last chip would remove the focus from that chip which makes all chip to lose focus. But expected at least one chip to have focus.
Ah nice, thanks. I've fixed that and added some tests for it. |
🤖 Beep boop! Screenshot test report 🚦2 screenshots changed from Details2 Changed: |
🤖 Beep boop! Screenshot test report 🚦2 screenshots changed from Details2 Changed: |
🤖 Beep boop! Screenshot test report 🚦2 screenshots changed from Details2 Changed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few more comments.
🤖 Beep boop! Screenshot test report 🚦2 screenshots changed from Details2 Changed: |
Add support for keyboard navigation for chips. Update ripple focus-within mixin behavior.
Demos: action chips, choice chips, filter chips, and input chips.
Fixes #2259
BREAKING CHANGE: Chips markup, adapters, foundations, and events have changed.