Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(snackbar): add feature targeting for styles #4876

Merged

Conversation

crisbeto
Copy link
Collaborator

@crisbeto crisbeto commented Jul 4, 2019

Adds support for feature targeting to the mdc-snackbar styles.

Relates to #4227.

@crisbeto
Copy link
Collaborator Author

crisbeto commented Jul 4, 2019

Here's a comparison between the before and after styles. A couple of lines had to be moved around so that they'd fit into the mixins.

before.css.txt
after.css.txt

packages/mdc-snackbar/_mixins.scss Outdated Show resolved Hide resolved
packages/mdc-snackbar/_mixins.scss Show resolved Hide resolved
Adds support for feature targeting to the `mdc-snackbar` styles.

Relates to material-components#4227.
@crisbeto crisbeto force-pushed the snackbar-feature-targeting branch from 3d34cb3 to 8310b03 Compare July 8, 2019 20:11
@crisbeto
Copy link
Collaborator Author

crisbeto commented Jul 8, 2019

Thank you for the feedback @abhiomkar, it should all be addressed now. Can you take another look?

@codecov-io
Copy link

codecov-io commented Jul 8, 2019

Codecov Report

Merging #4876 into master will increase coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #4876     +/-   ##
=========================================
+ Coverage   98.86%   99.16%   +0.3%     
=========================================
  Files         119      119             
  Lines        5650     5650             
  Branches      749      749             
=========================================
+ Hits         5586     5603     +17     
+ Misses         63       46     -17     
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-checkbox/component.ts 96.87% <0%> (+1.04%) ⬆️
packages/mdc-tab/component.ts 98.36% <0%> (+3.27%) ⬆️
packages/mdc-base/component.ts 100% <0%> (+3.57%) ⬆️
packages/mdc-ripple/component.ts 100% <0%> (+3.77%) ⬆️
packages/mdc-auto-init/index.ts 100% <0%> (+4.16%) ⬆️
packages/mdc-ripple/util.ts 97.56% <0%> (+4.87%) ⬆️
packages/mdc-switch/component.ts 98.27% <0%> (+6.89%) ⬆️
packages/mdc-radio/component.ts 95.83% <0%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8fbf5...3c19c26. Read the comment docs.

@abhiomkar abhiomkar merged commit 1b7aea1 into material-components:master Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants