feat(bottom-navigation): Add bottom-navigation component #5022

ghost · 2019-08-23T07:26:13Z

closes #59

codecov-io · 2019-08-23T07:30:54Z

Codecov Report

Merging #5022 into master will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5022      +/-   ##
==========================================
+ Coverage   98.79%   99.09%   +0.29%     
==========================================
  Files         122      122              
  Lines        5830     5830              
  Branches      763      763              
==========================================
+ Hits         5760     5777      +17     
+ Misses         69       52      -17     
  Partials        1        1

Impacted Files	Coverage Δ
packages/mdc-checkbox/component.ts	`96.87% <0%> (+1.04%)`	⬆️
packages/mdc-tab/component.ts	`98.36% <0%> (+3.27%)`	⬆️
packages/mdc-base/component.ts	`100% <0%> (+3.57%)`	⬆️
packages/mdc-ripple/component.ts	`100% <0%> (+3.77%)`	⬆️
packages/mdc-auto-init/index.ts	`100% <0%> (+4.16%)`	⬆️
packages/mdc-ripple/util.ts	`97.56% <0%> (+4.87%)`	⬆️
packages/mdc-switch/component.ts	`98.27% <0%> (+6.89%)`	⬆️
packages/mdc-radio/component.ts	`95.83% <0%> (+8.33%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 805d098...4959f5e. Read the comment docs.

ghost · 2019-09-05T03:33:51Z

@abhiomkar
I almost finish this work.
And I need a help...
I deleted this code because there is type error. (35f44a1)
But this code works fine.
I don't know cause of error.
Can you help me??

ghost · 2019-09-10T01:50:23Z

Please reopen when you start review.

karocksjoelee · 2021-03-05T17:06:56Z

What's wrong with this?

This squashes the PR of TroyTae to base my changes upon. Merges material-components#5022. commit 4959f5e Author: Troy Tae <tjy970721@gmail.com> Date: Thu Sep 5 15:13:05 2019 +0900 feat(bottom-navigation): fix lint commit 80c678e Author: Troy Tae <tjy970721@gmail.com> Date: Thu Sep 5 15:05:59 2019 +0900 feat(bottom-navigation): split function & write comment commit aa31976 Author: Troy Tae <tjy970721@gmail.com> Date: Thu Sep 5 12:31:51 2019 +0900 feat(bottom-navigation): apply acceleration commit ff1d809 Author: Troy Tae <tjy970721@gmail.com> Date: Mon Sep 2 17:01:40 2019 +0900 feat(bottom-navigation): fix error commit 35f44a1 Author: Troy Tae <tjy970721@gmail.com> Date: Mon Sep 2 16:39:16 2019 +0900 feat(bottom-navigation): delete test code commit bd2b88a Author: Troy Tae <tjy970721@gmail.com> Date: Mon Sep 2 16:38:05 2019 +0900 feat(bottom-navigation): scroll animation commit 5e0cd14 Author: Troy Tae <tjy970721@gmail.com> Date: Mon Sep 2 15:44:14 2019 +0900 feat(bottom-navigation): scroll handler commit 905f299 Author: Troy Tae <tjy970721@gmail.com> Date: Thu Aug 29 19:21:16 2019 +0900 feat(bottom-navigation): define cssClasses/strings commit dec3981 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 17:41:18 2019 +0900 feat(bottom-navigation): fix README.md for lint commit bff1c49 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 16:55:49 2019 +0900 feat(bottom-navigation): component commit cbfa7b2 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 15:59:59 2019 +0900 feat(bottom-navigation): write README.md for lint commit e3cbb84 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 15:54:53 2019 +0900 feat(bottom-navigation): foundation commit 1897c45 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 12:13:07 2019 +0900 feat(bottom-navigation): define adapter commit 496b745 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 12:00:06 2019 +0900 feat(bottom-navigation): define constants commit 27884b0 Author: Troy Tae <tjy970721@gmail.com> Date: Mon Aug 26 15:59:51 2019 +0900 feat(bottom-navigation): fix lint commit c8cb97e Author: Troy Tae <tjy970721@gmail.com> Date: Mon Aug 26 15:58:34 2019 +0900 feat(bottom-navigation): box-shadow for scrolled state commit 533fe6b Author: Troy Tae <tjy970721@gmail.com> Date: Mon Aug 26 15:43:49 2019 +0900 feat(bottom-navigation): allow stacked menu commit 80ce7ac Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 19:23:16 2019 +0900 feat(bottom-navigation): declare style variable commit ca4cac7 Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 18:56:46 2019 +0900 feat(bottom-navigation): support inline icon/label commit 92da319 Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 16:40:00 2019 +0900 feat(bottom-navigation): fix lint commit 6f3e8f8 Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 16:22:48 2019 +0900 feat(bottom-navigation): menu ripple commit 9943778 Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 15:48:51 2019 +0900 feat(bottom-navigation): write component commit 86b8621 Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 12:39:21 2019 +0900 feat(bottom-navigation): configuration bottom-navigation environment

Updates PR material-components#5022 to work with the most recent master branch.

This squashes the PR of TroyTae to base my changes upon. Merges material-components#5022. commit 4959f5e Author: Troy Tae <tjy970721@gmail.com> Date: Thu Sep 5 15:13:05 2019 +0900 feat(bottom-navigation): fix lint commit 80c678e Author: Troy Tae <tjy970721@gmail.com> Date: Thu Sep 5 15:05:59 2019 +0900 feat(bottom-navigation): split function & write comment commit aa31976 Author: Troy Tae <tjy970721@gmail.com> Date: Thu Sep 5 12:31:51 2019 +0900 feat(bottom-navigation): apply acceleration commit ff1d809 Author: Troy Tae <tjy970721@gmail.com> Date: Mon Sep 2 17:01:40 2019 +0900 feat(bottom-navigation): fix error commit 35f44a1 Author: Troy Tae <tjy970721@gmail.com> Date: Mon Sep 2 16:39:16 2019 +0900 feat(bottom-navigation): delete test code commit bd2b88a Author: Troy Tae <tjy970721@gmail.com> Date: Mon Sep 2 16:38:05 2019 +0900 feat(bottom-navigation): scroll animation commit 5e0cd14 Author: Troy Tae <tjy970721@gmail.com> Date: Mon Sep 2 15:44:14 2019 +0900 feat(bottom-navigation): scroll handler commit 905f299 Author: Troy Tae <tjy970721@gmail.com> Date: Thu Aug 29 19:21:16 2019 +0900 feat(bottom-navigation): define cssClasses/strings commit dec3981 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 17:41:18 2019 +0900 feat(bottom-navigation): fix README.md for lint commit bff1c49 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 16:55:49 2019 +0900 feat(bottom-navigation): component commit cbfa7b2 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 15:59:59 2019 +0900 feat(bottom-navigation): write README.md for lint commit e3cbb84 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 15:54:53 2019 +0900 feat(bottom-navigation): foundation commit 1897c45 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 12:13:07 2019 +0900 feat(bottom-navigation): define adapter commit 496b745 Author: Troy Tae <tjy970721@gmail.com> Date: Wed Aug 28 12:00:06 2019 +0900 feat(bottom-navigation): define constants commit 27884b0 Author: Troy Tae <tjy970721@gmail.com> Date: Mon Aug 26 15:59:51 2019 +0900 feat(bottom-navigation): fix lint commit c8cb97e Author: Troy Tae <tjy970721@gmail.com> Date: Mon Aug 26 15:58:34 2019 +0900 feat(bottom-navigation): box-shadow for scrolled state commit 533fe6b Author: Troy Tae <tjy970721@gmail.com> Date: Mon Aug 26 15:43:49 2019 +0900 feat(bottom-navigation): allow stacked menu commit 80ce7ac Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 19:23:16 2019 +0900 feat(bottom-navigation): declare style variable commit ca4cac7 Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 18:56:46 2019 +0900 feat(bottom-navigation): support inline icon/label commit 92da319 Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 16:40:00 2019 +0900 feat(bottom-navigation): fix lint commit 6f3e8f8 Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 16:22:48 2019 +0900 feat(bottom-navigation): menu ripple commit 9943778 Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 15:48:51 2019 +0900 feat(bottom-navigation): write component commit 86b8621 Author: Troy Tae <tjy970721@gmail.com> Date: Fri Aug 23 12:39:21 2019 +0900 feat(bottom-navigation): configuration bottom-navigation environment

Updates PR material-components#5022 to work with the most recent master branch.

Troy Tae added 3 commits August 23, 2019 12:39

feat(bottom-navigation): configuration bottom-navigation environment

86b8621

feat(bottom-navigation): write component

9943778

feat(bottom-navigation): menu ripple

6f3e8f8

googlebot added the cla: yes label Aug 23, 2019

Troy Tae added 11 commits August 23, 2019 16:40

feat(bottom-navigation): fix lint

92da319

feat(bottom-navigation): support inline icon/label

ca4cac7

feat(bottom-navigation): declare style variable

80ce7ac

feat(bottom-navigation): allow stacked menu

533fe6b

feat(bottom-navigation): box-shadow for scrolled state

c8cb97e

feat(bottom-navigation): fix lint

27884b0

feat(bottom-navigation): define constants

496b745

feat(bottom-navigation): define adapter

1897c45

feat(bottom-navigation): foundation

e3cbb84

feat(bottom-navigation): write README.md for lint

cbfa7b2

feat(bottom-navigation): component

bff1c49

ghost changed the title ~~feat(bottom-navigation): component~~ feat(bottom-navigation): Add bottom-navigation component Aug 28, 2019

Troy Tae added 7 commits August 28, 2019 17:41

feat(bottom-navigation): fix README.md for lint

dec3981

feat(bottom-navigation): define cssClasses/strings

905f299

feat(bottom-navigation): scroll handler

5e0cd14

feat(bottom-navigation): scroll animation

bd2b88a

feat(bottom-navigation): delete test code

35f44a1

feat(bottom-navigation): fix error

ff1d809

feat(bottom-navigation): apply acceleration

aa31976

Troy Tae added 2 commits September 5, 2019 15:05

feat(bottom-navigation): split function & write comment

80c678e

feat(bottom-navigation): fix lint

4959f5e

ghost closed this Sep 10, 2019

shoeffner added a commit to shoeffner/material-components-web that referenced this pull request Feb 6, 2022

feat(bottom-navigation): Update to 13.0.0

8002e64

Updates PR material-components#5022 to work with the most recent master branch.

shoeffner added a commit to shoeffner/material-components-web that referenced this pull request Feb 6, 2022

feat(bottom-navigation): Update to 13.0.0

61b54e1

Updates PR material-components#5022 to work with the most recent master branch.

shoeffner added a commit to shoeffner/material-components-web that referenced this pull request Feb 6, 2022

feat(bottom-navigation): Update to 13.0.0

dbcf50d

Updates PR material-components#5022 to work with the most recent master branch.

shoeffner mentioned this pull request Feb 6, 2022

feat: Bottom navigation #7534

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(bottom-navigation): Add bottom-navigation component #5022

feat(bottom-navigation): Add bottom-navigation component #5022

ghost commented Aug 23, 2019 •

edited by ghost

Loading

codecov-io commented Aug 23, 2019 •

edited

Loading

ghost commented Sep 5, 2019

ghost commented Sep 10, 2019

karocksjoelee commented Mar 5, 2021

feat(bottom-navigation): Add bottom-navigation component #5022

feat(bottom-navigation): Add bottom-navigation component #5022

Conversation

ghost commented Aug 23, 2019 • edited by ghost Loading

codecov-io commented Aug 23, 2019 • edited Loading

Codecov Report

ghost commented Sep 5, 2019

ghost commented Sep 10, 2019

karocksjoelee commented Mar 5, 2021

ghost commented Aug 23, 2019 •

edited by ghost

Loading

codecov-io commented Aug 23, 2019 •

edited

Loading