Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-field): Fixes input text alignment on IE11 for densed textfield 2 #5147

Merged
merged 1 commit into from
Oct 3, 2019
Merged

fix(text-field): Fixes input text alignment on IE11 for densed textfield 2 #5147

merged 1 commit into from
Oct 3, 2019

Conversation

abhiomkar
Copy link
Collaborator

@abhiomkar abhiomkar commented Oct 2, 2019 •
edited
Loading

Other changes:

  • notched-outline: Remove padding calculation from notch offset
  • Removed applying color to asterisk since it is inherited from parent (floating label).

This PR keeps text field in sync with internal version.

@abhiomkar abhiomkar requested a review from joyzhong October 2, 2019 18:45
@mdc-web-bot
Copy link
Collaborator

All 755 screenshot tests passed for commit 87a5c7c vs. develop! 💯🎉

@abhiomkar abhiomkar changed the title fix(notched-outline): Remove padding calculation from notch offset fix(text-field): Fixes input text alignment on IE11 for densed textfield 2 Oct 2, 2019
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from develop on commit 4602d51:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from develop on commit 591b2a6:

Details

@abhiomkar abhiomkar requested a review from patrickrodee October 3, 2019 15:30
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

4 screenshots changed from develop on commit 52582ac:

Details

patrickrodee
patrickrodee approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@patrickrodee patrickrodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@abhiomkar abhiomkar merged commit c8f7693 into develop Oct 3, 2019
@abhiomkar abhiomkar deleted the fix/textfield_sync branch October 3, 2019 16:41
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
Merged
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickrodee patrickrodee patrickrodee approved these changes

@joyzhong joyzhong Awaiting requested review from joyzhong

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhiomkar @mdc-web-bot @patrickrodee @googlebot