Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

fix(linear-progress): Restore buffer after determinate is toggled. #5156

Merged
merged 1 commit into from
Oct 7, 2019
Merged

fix(linear-progress): Restore buffer after determinate is toggled. #5156

merged 1 commit into from
Oct 7, 2019

Conversation

ericfromgoogle
Copy link
Contributor

@ericfromgoogle ericfromgoogle commented Oct 4, 2019 •
edited by abhiomkar
Loading

Fixes #4491

@ericfromgoogle ericfromgoogle changed the title fix(linear-progress): Restore buffer after indeterminite is toggled. #4491 fix(linear-progress): Restore buffer after determinate is toggled. #4491 Oct 4, 2019
@codecov-io
Copy link

codecov-io commented Oct 4, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@c8f7693). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5156   +/-   ##
==========================================
  Coverage           ?   98.95%           
==========================================
  Files              ?      122           
  Lines              ?     6042           
  Branches           ?      798           
==========================================
  Hits               ?     5979           
  Misses             ?       62           
  Partials           ?        1
Impacted Files Coverage Δ
packages/mdc-linear-progress/foundation.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8f7693...e9c648f. Read the comment docs.

@aprigogin aprigogin requested a review from abhiomkar October 7, 2019 19:18
abhiomkar
abhiomkar approved these changes Oct 7, 2019
View reviewed changes
Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@abhiomkar abhiomkar changed the title fix(linear-progress): Restore buffer after determinate is toggled. #4491 fix(linear-progress): Restore buffer after determinate is toggled. Oct 7, 2019
@abhiomkar abhiomkar merged commit 09b1598 into material-components:develop Oct 7, 2019
@ericfromgoogle ericfromgoogle deleted the develop branch October 7, 2019 19:36
@ericfromgoogle
Copy link
Contributor Author

No problem, glad to help!

@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
Merged
93 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abhiomkar abhiomkar abhiomkar approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericfromgoogle @codecov-io @abhiomkar @googlebot