This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(linear-progress): Add aria attributes to linear progress bar to support screen readers #5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5248 +/- ##
==========================================
+ Coverage 98.63% 98.91% +0.28%
==========================================
Files 122 122
Lines 6002 6011 +9
Branches 774 774
==========================================
+ Hits 5920 5946 +26
+ Misses 81 64 -17
Partials 1 1
Continue to review full report at Codecov.
|
rbuckheit
force-pushed
the
fix/linearprogress-aria
branch
from
2b8e67b to
15b5099
Compare
rbuckheit
changed the title
rbuckheit
changed the title
joyzhong
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Looks great! Please add a BREAKING CHANGE message to the description per https://github.com/angular/angular/blob/master/CONTRIBUTING.md#footer, since we're adding two adapter methods.
Also create the equivalent CL in google3. I will merge this in when that CL is ready to go.
rbuckheit
force-pushed
the
fix/linearprogress-aria
branch
2 times, most recently
from
2acd374 to
d1ce40e
Compare
abhiomkar
reviewed
Nov 12, 2019
abhiomkar
changed the title
Adds aria attributes to MDC Linear progress to support screen readers. BREAKING CHANGE: Adds new adapter methods to MDCLinearProgressAdapter.
rbuckheit
force-pushed
the
fix/linearprogress-aria
branch
from
d1ce40e to
675c9c7
Compare
Squashed and added that to the commit message :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(linear-progress) support aria attributes
Adds aria attributes to MDC Linear progress to support screen readers.
BREAKING CHANGE: Adds new adapter methods to MDCLinearProgressAdapter.