Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Conversation

asyncliz
Copy link
Contributor

No description provided.

@asyncliz asyncliz requested a review from allan-chen December 18, 2019 18:55
@asyncliz asyncliz self-assigned this Dec 18, 2019
@asyncliz asyncliz changed the title Fix disabled placeholder color fix(textfield): add placeholder mixins and disabled placeholder color Dec 18, 2019
Copy link
Collaborator

@allan-chen allan-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, left some minor comments

@asyncliz asyncliz requested a review from allan-chen December 18, 2019 21:28
Copy link
Collaborator

@allan-chen allan-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's sync to internal

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #5355 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5355      +/-   ##
==========================================
- Coverage   98.39%   98.31%   -0.08%     
==========================================
  Files         163      163              
  Lines        6307     6309       +2     
  Branches      863      864       +1     
==========================================
- Hits         6206     6203       -3     
- Misses        101      106       +5
Impacted Files Coverage Δ
packages/mdc-radio/component.ts 87.5% <0%> (-8.16%) ⬇️
packages/mdc-radio/foundation.ts 81.81% <0%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac43eb...3a4195c. Read the comment docs.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@asyncliz asyncliz force-pushed the fix/textfield/disabled-placeholder-color branch from 38c65db to 3a4195c Compare December 18, 2019 23:23
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@asyncliz asyncliz deleted the fix/textfield/disabled-placeholder-color branch January 3, 2020 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants