-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(textfield): add placeholder mixins and disabled placeholder color #5355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, left some minor comments
🤖 Beep boop! Screenshot test report 🚦12 screenshots changed from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's sync to internal
Codecov Report
@@ Coverage Diff @@
## master #5355 +/- ##
==========================================
- Coverage 98.39% 98.31% -0.08%
==========================================
Files 163 163
Lines 6307 6309 +2
Branches 863 864 +1
==========================================
- Hits 6206 6203 -3
- Misses 101 106 +5
Continue to review full report at Codecov.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
38c65db
to
3a4195c
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
🤖 Beep boop! Screenshot test report 🚦12 screenshots changed from |
No description provided.