Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Conversation

allan-chen
Copy link
Collaborator

Project import generated by Copybara.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@allan-chen allan-chen changed the title Project import generated by Copybara. test(textfield): Migrate component unit test for icon to Jasmine Jan 7, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@allan-chen allan-chen requested a review from abhiomkar January 7, 2020 22:08
@codecov-io
Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #5423 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5423   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files         164      164           
  Lines        6259     6259           
  Branches      831      831           
=======================================
  Hits         6080     6080           
  Misses        179      179
Impacted Files Coverage Δ
packages/mdc-textfield/component.ts 97.95% <100%> (ø) ⬆️
packages/mdc-switch/component.ts 91.52% <0%> (-6.78%) ⬇️
packages/mdc-auto-init/index.ts 92% <0%> (-4%) ⬇️
packages/mdc-textfield/icon/component.ts 100% <0%> (+26.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c708d...a9c4cff. Read the comment docs.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jan 7, 2020
@mdc-web-bot
Copy link
Collaborator

All 602 screenshot tests passed for commit b06b822 vs. master! 💯🎉

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: no label Jan 8, 2020
@allan-chen allan-chen requested a review from joyzhong January 8, 2020 19:52
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

PiperOrigin-RevId: 288566407
@mdc-web-bot
Copy link
Collaborator

All 602 screenshot tests passed for commit e19c7a3 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 602 screenshot tests passed for commit d8859d2 vs. master! 💯🎉

Copy link
Contributor

@asyncliz asyncliz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdc-web-bot
Copy link
Collaborator

All 602 screenshot tests passed for commit 13447c8 vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 602 screenshot tests passed for commit a9c4cff vs. master! 💯🎉

@allan-chen allan-chen merged commit 5ed9d13 into master Jan 8, 2020
@allan-chen allan-chen deleted the cl_288566407 branch January 8, 2020 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants