Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ripple): Use passive event listeners on adapter instantiation #649

Merged
merged 3 commits into from
May 18, 2017
Merged

perf(ripple): Use passive event listeners on adapter instantiation #649

merged 3 commits into from
May 18, 2017

Conversation

trimox
Copy link
Contributor

@trimox trimox commented May 15, 2017 •
edited
Loading

  • Add applyPassive code into mdc-ripple/util.js
  • Use applyPassive to instantiate the ripple adapter
  • Add tests for applyPassive

resolves #629

@trimox trimox changed the title Use passive event listeners on ripple adapter instantiation refactor(ripple): Use passive event listeners on adapter instantiation May 15, 2017
@trimox trimox changed the title refactor(ripple): Use passive event listeners on adapter instantiation perf(ripple): Use passive event listeners on adapter instantiation May 15, 2017
@codecov-io
Copy link

codecov-io commented May 15, 2017 •
edited
Loading

Codecov Report

Merging #649 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files          59       59              
  Lines        2457     2465       +8     
  Branches      284      287       +3     
==========================================
+ Hits         2455     2463       +8     
  Misses          2        2
Impacted Files Coverage Δ
packages/mdc-ripple/index.js 100% <100%> (ø) ⬆️
packages/mdc-ripple/util.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514a894...5527f56. Read the comment docs.

traviskaufman
traviskaufman approved these changes May 18, 2017
View reviewed changes
Copy link
Contributor

@traviskaufman traviskaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@traviskaufman traviskaufman merged commit 3dd9a13 into material-components:master May 18, 2017
@trimox trimox deleted the refactor/passive-events branch May 18, 2017 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traviskaufman traviskaufman traviskaufman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use passive event listeners for the ripple
3 participants
@trimox @codecov-io @traviskaufman