Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(button): Remove button's dependency on typography, by specifying letter-spacing #871

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

lynnmercier
Copy link
Contributor

This is the same code as the old pull request, but I closed the old one because I needed to sync this up with master again

@codecov-io
Copy link

codecov-io commented Jun 28, 2017

Codecov Report

Merging #871 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #871   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files          70       70           
  Lines        3199     3199           
  Branches      387      387           
=======================================
  Hits         3153     3153           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d73a60...8cbef18. Read the comment docs.

Copy link
Contributor

@yeelan0319 yeelan0319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMed!

@yeelan0319 yeelan0319 merged commit 6aea5b2 into master Jun 29, 2017
@lynnmercier lynnmercier deleted the refactor/button-2 branch July 12, 2017 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants