-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added src-tauri folder icon #2567
Conversation
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
This is my first contribution to the project. I believe everything is ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my first contribution to the project. I believe everything is ok
This icon is not pixel-perfect, the sides of the icon must fit the grid
If I have the opportunity, I will help to fix it
See https://pixp.lucode.ar/material-extensions/vscode-material-icon-theme/pull/2567
Also be sure to read https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#designing-pixel-perfect-icons
I see. I made these adjustments using an online tool, so I’d appreciate it if you could check if they’re correct and meet the requirements. I also added the "Closes" to link to the issue, but I’m not sure if I should just modify the existing comment or start a new one. I’ve been using GitHub for a while, but this is my first time contributing to larger repositories. |
Thanks @okineadev for helping me with this contribution. I hope I can help more and more in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, @thainanluiz!
I see the icons are still a bit off. The folder icon is designed to be vertically centered. If you check your icons in the grid, yours have 2 pixels above and 4 below. So, basically, all paths should be moved 1 pixel down to make them centered.
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |
Description
Added new folder-icon for src-tauri. Closes #2547
Contribution Guidelines