Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added src-tauri folder icon #2567

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Conversation

thainanluiz
Copy link
Contributor

@thainanluiz thainanluiz commented Aug 31, 2024

Description

Added new folder-icon for src-tauri. Closes #2547

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Aug 31, 2024
Copy link

github-actions bot commented Aug 31, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@thainanluiz
Copy link
Contributor Author

This is my first contribution to the project. I believe everything is ok

@okineadev
Copy link
Member

#2547

Add "Closes #2547" to the PR description, this will automatically close issue #2547 after merging this PR

Copy link
Member

@okineadev okineadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first contribution to the project. I believe everything is ok

This icon is not pixel-perfect, the sides of the icon must fit the grid

image

If I have the opportunity, I will help to fix it

See https://pixp.lucode.ar/material-extensions/vscode-material-icon-theme/pull/2567
Also be sure to read https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#designing-pixel-perfect-icons

@thainanluiz
Copy link
Contributor Author

imagem_2024-08-31_150000376

I see. I made these adjustments using an online tool, so I’d appreciate it if you could check if they’re correct and meet the requirements.

I also added the "Closes" to link to the issue, but I’m not sure if I should just modify the existing comment or start a new one. I’ve been using GitHub for a while, but this is my first time contributing to larger repositories.

@okineadev
Copy link
Member

I also added the "Closes" to link to the issue, but I’m not sure if I should just modify the existing comment or start a new one. I’ve been using GitHub for a while, but this is my first time contributing to larger repositories.

image

Add here

@thainanluiz
Copy link
Contributor Author

Thanks @okineadev for helping me with this contribution. I hope I can help more and more in the future

Copy link
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, @thainanluiz!

I see the icons are still a bit off. The folder icon is designed to be vertically centered. If you check your icons in the grid, yours have 2 pixels above and 4 below. So, basically, all paths should be moved 1 pixel down to make them centered.

image

@PKief PKief merged commit d15ab6a into material-extensions:main Sep 6, 2024
4 checks passed
Copy link

github-actions bot commented Sep 6, 2024

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request]: <src-tauri>
4 participants