Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zeabur file icon for zeabur deploy config file #2611

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

ridemountainpig
Copy link
Member

Description

Add zeabur file icon for Zeabur deploy config file.

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief
Copy link
Member

PKief commented Sep 24, 2024

Could you please take a look at this and this section of the contribution guidelines?

@ridemountainpig
Copy link
Member Author

Could you please take a look at this and this section of the contribution guidelines?

@PKief, thank you for your review. I have read the guidelines and edited the icon SVG.

Copy link
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested changes in this review will algn the icons to the grid, to make them pixel-perfect

image

->

image

icons/zeabur.svg Outdated Show resolved Hide resolved
icons/zeabur_light.svg Outdated Show resolved Hide resolved
ridemountainpig and others added 2 commits September 25, 2024 00:14
Co-authored-by: Lucas Colombo <lucasncolombo@gmail.com>
Signed-off-by: Yen Cheng Lin <92412722+ridemountainpig@users.noreply.github.com>
Co-authored-by: Lucas Colombo <lucasncolombo@gmail.com>
Signed-off-by: Yen Cheng Lin <92412722+ridemountainpig@users.noreply.github.com>
@PKief PKief merged commit 1c43094 into material-extensions:main Sep 24, 2024
4 checks passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants