This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Add Bidi utilities #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
July 26, 2018 00:15
…ationalization-ios into bidi
…terial-internationalization-ios into experimental-bidi
added 2 commits
July 26, 2018 00:21
jverkoey
approved these changes
Jul 30, 2018
Sources/NSLocale+MaterialRTL.m
Outdated
| + (BOOL)mdf_isDefaultLanguageRTL { | ||
| NSString *languageCode = [[NSLocale currentLocale] objectForKey:NSLocaleLanguageCode]; | ||
| NSLocaleLanguageDirection characterDirection = | ||
| [NSLocale characterDirectionForLanguage:languageCode]; |
There was a problem hiding this comment.
[stylenit] Indentation here and above.
Sources/NSString+MaterialBidi.h
Outdated
| NSLocaleLanguageDirectionUnknown. If NSLocaleLanguageDirectionUnknown, the direction of the string | ||
| will be calculated with mdf_calculatedLanguageDirection. | ||
|
|
||
| |contextDirection| must be specificed and cannot be unknown. Only |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes categories on NSString and NSLocale to assist clients in properly wrapping string with unicode bidi control characters to allow LTR and RTL script in the same string.