This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
Integration with codecov #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building on all branches for this test. Commenting this out for the time being. Trying this out. Altering the project file to generate test coverage files.
Merged
Current coverage is 67.75% (diff: 100%)
|
|
Thanks for the pull request! We have to check to see if we can grant codecov the permissions it wants. |
|
@ajsecord - Sounds good. I'm a big fan of using code coverage. codecov acts as a nice gatekeeper for PRs & has pretty sweet github integrations. I should really try using it for some of my other projects. |
|
The permissions for codecov are similar to Travis CI (no direct code access needed), so we should be good. I'll look into turning it on for the material-motion repos as well. |
|
We just enabled material-foundation for codecov.io. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6 for the rationale behind this PR.
Would need someone under the umbrella of the
material-foundationto actually enable integration withcodecov. Otherwise the badge on the README will not reflect the latest coverage measure on master.https://codecov.io/gh/seanoshea/material-text-accessibility-ios/commit/839e6231eb2e2cd32ddfb0e43a062921623ce0e8 shows what the current coverage is for the library which was generated by https://travis-ci.org/seanoshea/material-text-accessibility-ios/builds/148757829.