Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

v3.0.0 #121

Merged
merged 11 commits into from
Dec 10, 2018
Merged

v3.0.0 #121

merged 11 commits into from
Dec 10, 2018

Conversation

jverkoey
Copy link
Contributor

@jverkoey jverkoey commented Dec 7, 2018

No description provided.

Jeff Verkoeyen and others added 9 commits March 6, 2018 11:42
* Don't animate system views with the animator.

Notably, animating the status bar with the animator can cause all of the status bar elements to animate. This is not desirable and deviant from UIKit's implicit animator behavior, but at this time I don't see a way to mimic the same behavior without regressing on our support for animating unhosted layers.

* Remove unused spec item.
This increases the following versions:

- bazel from 0.11 to 0.20.0
- build_bazel_rules_apple from 7ea0557 to 0.9.0
- build_bazel_rules_swift to 0.4.0 (new)
- bazel_ios_warnings from v1.0.1 to v2.0.0
- Xcode from 8 to 9.
- Swift pinned to 3.
- Unit test upgraded to UI tests.
- MotionInterchange from v1.6.0 to v2.0.0
- Migrate from the bazel runner scripts to the explicit Xcode selection + run pattern used by material-components-ios (https://github.com/material-components/material-components-ios/blob/fe0099d65c4fa67a02d7b842baf16b540bb2fa86/.kokoro#L102)

Tested by running:

    ./.kokoro
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #121 into stable will increase coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable     #121      +/-   ##
==========================================
+ Coverage   86.75%   87.92%   +1.17%     
==========================================
  Files          26        9      -17     
  Lines        2544      613    -1931     
  Branches      158        0     -158     
==========================================
- Hits         2207      539    -1668     
+ Misses        323       74     -249     
+ Partials       14        0      -14
Impacted Files Coverage Δ
src/MDMMotionAnimator.m 86.63% <0%> (-1.67%) ⬇️
tests/unit/MotionAnimatorTests.swift
tests/unit/NonAdditiveAnimatorTests.swift
tests/unit/InstantAnimationTests.swift
tests/unit/MotionAnimatorTests.m
tests/unit/UIKitEquivalencyTests.swift
tests/unit/QuartzCoreBehavioralTests.swift
tests/unit/TimeScaleFactorTests.swift
...sts/unit/HeadlessLayerImplicitAnimationTests.swift
tests/unit/SpringTimingCurveTests.swift
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df8310...2f7d3af. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #121 into stable will increase coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable     #121      +/-   ##
==========================================
+ Coverage   86.75%   87.92%   +1.17%     
==========================================
  Files          26        9      -17     
  Lines        2544      613    -1931     
  Branches      158        0     -158     
==========================================
- Hits         2207      539    -1668     
+ Misses        323       74     -249     
+ Partials       14        0      -14
Impacted Files Coverage Δ
src/MDMMotionAnimator.m 86.63% <0%> (-1.67%) ⬇️
tests/unit/MotionAnimatorTests.swift
tests/unit/NonAdditiveAnimatorTests.swift
tests/unit/InstantAnimationTests.swift
tests/unit/MotionAnimatorTests.m
tests/unit/UIKitEquivalencyTests.swift
tests/unit/QuartzCoreBehavioralTests.swift
tests/unit/TimeScaleFactorTests.swift
...sts/unit/HeadlessLayerImplicitAnimationTests.swift
tests/unit/SpringTimingCurveTests.swift
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df8310...5ecc1d1. Read the comment docs.

@jverkoey jverkoey changed the title Release candidate v3.0.0 Dec 7, 2018
@jverkoey jverkoey merged commit 5ecc1d1 into stable Dec 10, 2018
@jverkoey jverkoey deleted the release-candidate branch December 10, 2018 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants