This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Resolve a static analyzer warning. #124
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning was:
nil passed to a callee that requires a non-null 3rd parameter
This warning was correctly identifying that the public API for the animator was mis-typed as nonnull. The API has been updated to reflect the fact that a nil value is accepted.
ianegordon
approved these changes
Mar 8, 2019
codeman7
approved these changes
Mar 8, 2019
Codecov Report
@@ Coverage Diff @@
## develop #124 +/- ##
========================================
Coverage 87.92% 87.92%
========================================
Files 9 9
Lines 613 613
========================================
Hits 539 539
Misses 74 74Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning was:
This warning was correctly identifying that the public API for the animator was mis-typed as nonnull. The API has been updated to reflect the fact that a nil value is accepted.